sadikovi commented on a change in pull request #34995:
URL: https://github.com/apache/spark/pull/34995#discussion_r776091154
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
##########
@@ -52,7 +52,7 @@ object ExternalCatalogUtils {
'\n', '\u000B', '\u000C', '\r', '\u000E', '\u000F', '\u0010', '\u0011',
'\u0012', '\u0013',
'\u0014', '\u0015', '\u0016', '\u0017', '\u0018', '\u0019', '\u001A',
'\u001B', '\u001C',
'\u001D', '\u001E', '\u001F', '"', '#', '%', '\'', '*', '/', ':', '=',
'?', '\\', '\u007F',
- '{', '[', ']', '^')
+ '{', '[', ']', '^', '.')
Review comment:
I don't know what happens in Hive as I don't know how to test that code,
I am happy to verify the changes there if someone can explain how to test these
changes in Hive.
My understanding from reading
https://github.com/apache/hive/blob/9857c4e584384f7b0a49c34bc2bdf876c2ea1503/common/src/java/org/apache/hadoop/hive/common/FileUtils.java#L300
is that any escaped sequence will be transformed correctly regardless of
`clist` - it is only used for writes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
