huaxingao commented on a change in pull request #34904:
URL: https://github.com/apache/spark/pull/34904#discussion_r776149870
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCScanBuilder.scala
##########
@@ -72,6 +72,9 @@ case class JDBCScanBuilder(
private var pushedGroupByCols: Option[Array[String]] = None
+ override def supportCompletePushDown: Boolean =
+ jdbcOptions.numPartitions.map(_ == 1).getOrElse(true)
Review comment:
In the case of multiple partitions, if partition columns are the same as
group by columns, should `supportCompletePushDown` be set to true as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
