yym1995 commented on a change in pull request #35038:
URL: https://github.com/apache/spark/pull/35038#discussion_r776170786
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -644,6 +645,28 @@ class OrcSourceSuite extends OrcSuite with
SharedSparkSession {
}
}
+ test("SPARK-37728: Reading nested columns with ORC vectorized reader should
not " +
Review comment:
> What I meant was that this should be in `OrcQuerySuite` instead of
`OrcSourceSuite` to provide a test coverage for v1 and v2.
This PR is a fix for [SPARK-34862]. The unit test "SPARK-34862: Support ORC
vectorized reader for nested column" is in OrcSourceSuite.scala on branch-3.2.
That's why I put my unit test in OrcSourceSuite.scala. Do you think I should
put it in OrcQuerySuite.scala?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
