Yaohua628 commented on pull request #35068: URL: https://github.com/apache/spark/pull/35068#issuecomment-1002946361
> I am not against this change, it's an improvement on top of current code anyway. Just want to think twice here as we are adding API method to `WritableColumnVector` which is public. > > As we discussed before, just wondering if we change the code path to use constant column vector in the future, won't it render this newly added API not used any more? > > btw @Yaohua628 just in case, please let me know if any help needed for constant column vector implementation, I can also help it out to implement it. > Yea I think a constant column vector is a better solution. got it, ya, make sense! will try to have a simple version of the constant column vector. @c21 thanks for offering, will reach out to you if I need any help. thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
