Daniel-Davies commented on pull request #35032: URL: https://github.com/apache/spark/pull/35032#issuecomment-1003051764
Yes, the ones I saw were: - F.when: Completely agree, I think we should leave this one alone - F.overlay: Annotation only - F.least: Annotation only - F.slice: Needs a conversion - F.array_repeat: Needs a conversion - F.percentile_approx: I don't think this should take a column name either way though So really there are only two annotation changes & two column conversions needed from what I can see. Happy to update these, or if you don't think they're worth pursuing/ have reasons for being this way, we may want to leave them alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
