LuciferYang edited a comment on pull request #34991: URL: https://github.com/apache/spark/pull/34991#issuecomment-1003301172
@dongjoon-hyun @srowen I found that `objenesis ` as `compile` scope dependency comes from `kryo-shaded`. Take `common/unsafe` module as an example, the dependency chain is as follows: - spark-unsafe_2.12 -> `com.twitter:chill_2.12:0.10.0` -> `com.esotericsoftware:kryo-shaded:4.0.2` -> `org.objenesis:objenesis:2.5.1:compile` - spark-unsafe_2.12 -> `org.mockito:mockito-core:3.12.4` -> `org.objenesis:objenesis:3.2:test` Therefore, for the `common/unsafe` module, we can see from the dependency tree that `objenesis` is the `compile` scope and the version change from 2.6 to 3.2 because this pr upgrade mockito from 3.4.x to 3.12.x. In order to test compatibility, I did the following tests 1. Manually clone a kryo repository: `git clone [email protected]:EsotericSoftware/kryo.git kryo` 2. Switch to `kryo-parent-4.0.2 ` tag: `git checkout -b kryo-parent-4.0.2 kryo-parent-4.0.2 ` 3. Manually change `objenesis` version from `2.5.1` to `3.2` ``` diff --git a/pom.xml b/pom.xml index 3d808a7..94d0aa3 100644 --- a/pom.xml +++ b/pom.xml @@ -71,7 +71,7 @@ <dependency> <groupId>org.objenesis</groupId> <artifactId>objenesis</artifactId> - <version>2.5.1</version> + <version>3.2</version> </dependency> ``` 4. Execute `mvn clean test` and all UTs passed. ``` Results : Tests run: 220, Failures: 0, Errors: 0, Skipped: 1 ``` So I think this pr upgrade `objenesis` is safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
