srowen commented on pull request #35078: URL: https://github.com/apache/spark/pull/35078#issuecomment-1003407074
I find that fairly convincing for x86. I'm worried about ARM - not just performance but correctness. ARMv7 supports unaligned access; ARMv5 does not. But v7 seems to have some 'gotchas' that direct access like this may hit. If ARM JDKs show up as 'aligned' then I think this is fine, but that's what I don't know right now. Do you have any easy way to check that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
