beliefer commented on a change in pull request #35070:
URL: https://github.com/apache/spark/pull/35070#discussion_r777333508
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -209,6 +210,11 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
}
}
+ private def supportPartialAggPushDown(agg: Aggregation): Boolean = {
+ // We don't know the agg buffer of `GeneralAggregateFunc`, so can't do
partial agg push down.
+ agg.aggregateExpressions().exists(_.isInstanceOf[GeneralAggregateFunc])
Review comment:
If exists `GeneralAggregateFunc`, we cannot partial aggregate push-down
and still could complete aggregate push-down. I think
`!agg.aggregateExpressions().exists(_.isInstanceOf[GeneralAggregateFunc])`
looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
