sathiyapk commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r778020451
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -279,6 +280,49 @@ case class Ceil(child: Expression) extends
UnaryMathExpression(math.ceil, "CEIL"
override protected def withNewChildInternal(newChild: Expression): Ceil =
copy(child = newChild)
}
+object Ceil {
+ def apply(child: Expression, scale: Expression): Expression = {
Review comment:
This `Ceil` object serves few unit tests in `MathExpressionsSuite`. I am
not sure, we can do the same with only `CeilExpressionBuilder` :
`checkEvaluation(checkDataTypeAndCast(Ceil(doublePi, scale)),
doubleResultsCeil(i), EmptyRow)`
Could we ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
