bersprockets commented on a change in pull request #35090:
URL: https://github.com/apache/spark/pull/35090#discussion_r778444805



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala
##########
@@ -294,6 +294,38 @@ object OrcReadBenchmark extends SqlBasedBenchmark {
     }
   }
 
+  def structBenchmark(values: Int, width: Int): Unit = {

Review comment:
       @dongjoon-hyun 
   Created pull request for new benchmarks: #35100. I also added a benchmark 
for structs contained by arrays (to test whether copying rows is any faster or 
slower than creating new rows), as requested by @HyukjinKwon 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to