cloud-fan commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r778700281
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -691,6 +803,19 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(BRound(Literal.create(null, dataType), Literal(2)), null)
checkEvaluation(BRound(Literal.create(null, dataType),
Literal.create(null, IntegerType)), null)
+ checkEvaluation(checkDataTypeAndCast(
+ RoundFloor(Literal.create(null, dataType), Literal(2))), null)
+ try {
+ checkEvaluation(checkDataTypeAndCast(RoundFloor(Literal.create(null,
dataType),
+ Literal.create(null, IntegerType))), null)
+ checkEvaluation(checkDataTypeAndCast(RoundCeil(Literal.create(null,
dataType),
Review comment:
it looks weird to test the error behavior in this test case. Can we move
it to `ceil-floor-with-scale-param.sql`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
