cloud-fan commented on a change in pull request #35101:
URL: https://github.com/apache/spark/pull/35101#discussion_r779303049
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -721,6 +721,26 @@ object DataSourceStrategy
Some(new Sum(FieldReference(name), agg.isDistinct))
case aggregate.Average(PushableColumnWithoutNestedColumn(name), _) =>
Some(new GeneralAggregateFunc("AVG", agg.isDistinct,
Array(FieldReference(name))))
+ case aggregate.VariancePop(PushableColumnWithoutNestedColumn(name), _)
=>
+ Some(new GeneralAggregateFunc("VAR_POP", agg.isDistinct,
Array(FieldReference(name))))
+ case aggregate.VarianceSamp(PushableColumnWithoutNestedColumn(name),
_) =>
+ Some(new GeneralAggregateFunc("VAR_SAMP", agg.isDistinct,
Array(FieldReference(name))))
+ case aggregate.StddevPop(PushableColumnWithoutNestedColumn(name), _) =>
+ Some(new GeneralAggregateFunc("STDDEV_POP", agg.isDistinct,
Array(FieldReference(name))))
+ case aggregate.StddevSamp(PushableColumnWithoutNestedColumn(name), _)
=>
+ Some(new GeneralAggregateFunc("STDDEV_SAMP", agg.isDistinct,
Array(FieldReference(name))))
+ case aggregate.CovPopulation(PushableColumnWithoutNestedColumn(left),
+ PushableColumnWithoutNestedColumn(right), _) =>
+ Some(new GeneralAggregateFunc("COVAR_POP", agg.isDistinct,
+ Array(FieldReference(left), FieldReference(right))))
+ case aggregate.CovSample(PushableColumnWithoutNestedColumn(left),
+ PushableColumnWithoutNestedColumn(right), _) =>
+ Some(new GeneralAggregateFunc("COVAR_SAMP", agg.isDistinct,
+ Array(FieldReference(left), FieldReference(right))))
+ case aggregate.Corr(PushableColumnWithoutNestedColumn(left),
+ PushableColumnWithoutNestedColumn(right), _) =>
+ Some(new GeneralAggregateFunc("CORR", agg.isDistinct,
+ Array(FieldReference(left), FieldReference(right))))
Review comment:
please update the classdoc of `GeneralAggregateFunc` to include these
new functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
