dongjoon-hyun commented on pull request #35112:
URL: https://github.com/apache/spark/pull/35112#issuecomment-1006300824


   Could you review this again, @HyukjinKwon ? I addressed all comments.
   
   - Move to `sparktestsupport` folder.
   - Fix all Python linter issues including removing `import *`.
   - Check `utils.py` doctest inside `sparktestsupport`.
   
   ```bash
   $ python3 -m doctest -v sparktestsupport/utils.py | tail -n11
   3 items had no tests:
       utils
       utils._test
       utils.determine_tags_to_exclude
   3 items passed all tests:
      3 tests in utils.determine_modules_for_files
      8 tests in utils.determine_modules_to_test
      2 tests in utils.identify_changed_files_from_git_commits
   13 tests in 6 items.
   13 passed and 0 failed.
   Test passed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to