cloud-fan commented on a change in pull request #35004:
URL: https://github.com/apache/spark/pull/35004#discussion_r779548331



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -190,15 +196,23 @@ case class ResolvedView(identifier: Identifier, isTemp: 
Boolean) extends LeafNod
 }
 
 /**
- * A plan containing resolved function.
+ * A plan containing resolved persistent function.
  */
-// TODO: create a generic representation for v1, v2 function, after we add 
function
-//       support to v2 catalog. For now we only need the identifier to 
fallback to v1 command.
-case class ResolvedFunc(identifier: Identifier)
+case class ResolvedPersistentFunc(
+    catalog: FunctionCatalog,
+    identifier: Identifier,
+    func: UnboundFunction)
   extends LeafNode {
   override def output: Seq[Attribute] = Nil
 }
 
+/**
+ * A plan containing resolved non-persistent (temp or built-in) function.
+ */
+case class ResolvedNonPersistentFunc(name: String, func: UnboundFunction) 
extends LeafNode {

Review comment:
       Yes for now, but it's not necessary to have this limitation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to