cloud-fan commented on a change in pull request #34914:
URL: https://github.com/apache/spark/pull/34914#discussion_r779588827
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTable.scala
##########
@@ -161,7 +162,11 @@ class InMemoryTable(
case (v, t) =>
throw new IllegalArgumentException(s"Match: unsupported
argument(s) type - ($v, $t)")
}
- case BucketTransform(numBuckets, ref, _) =>
+ case BucketTransform(numBuckets, ref) =>
Review comment:
I think we can have a single `BucketTransform.unapply`, to match both
`BucketTransform` and `SortedBucketTransform`, so that we can have a single
case here and avoid duplicated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
