zero323 commented on a change in pull request #35123:
URL: https://github.com/apache/spark/pull/35123#discussion_r780017923
##########
File path: python/pyspark/tests/test_readwrite.py
##########
@@ -231,8 +231,9 @@ def test_newhadoop(self):
)
self.assertEqual(result, data)
+ fmt = "org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat"
conf = {
- "mapreduce.job.outputformat.class":
"org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat",
+ "mapreduce.job.outputformat.class": fmt,
Review comment:
I don't feel strongly about it, but brackets should work in such cases,
without introducing new variables
```python
"mapreduce.job.outputformat.class": (
"org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat"
),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
