viirya commented on a change in pull request #34914:
URL: https://github.com/apache/spark/pull/34914#discussion_r780047246
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -112,26 +111,21 @@ private[sql] final case class BucketTransform(
override def arguments: Array[Expression] = numBuckets +: columns.toArray
- override def toString: String =
- if (sortedColumns.nonEmpty) {
- s"bucket(${arguments.map(_.describe).mkString(", ")}," +
- s" ${sortedColumns.map(_.describe).mkString(", ")})"
- } else {
- s"bucket(${arguments.map(_.describe).mkString(", ")})"
- }
+ override def describe: String =
s"bucket(${arguments.map(_.describe).mkString(", ")})"
+
+ override def toString: String = describe
override def withReferences(newReferences: Seq[NamedReference]): Transform =
{
this.copy(columns = newReferences)
}
}
private[sql] object BucketTransform {
- def unapply(expr: Expression): Option[(Int, FieldReference, FieldReference)]
=
- expr match {
+ def unapply(expr: Expression): Option[(Int, FieldReference, FieldReference)]
= expr match {
Review comment:
Could you add some comments on `unapply` (if it is really used) about
what it returns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
