cloud-fan commented on a change in pull request #35132:
URL: https://github.com/apache/spark/pull/35132#discussion_r780459615
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
##########
@@ -305,6 +305,12 @@ private[orc] class OrcOutputWriter(
recordWriter.close(Reporter.NULL)
}
}
+
+ /**
+ * If `recordWriterInstantiated` is false, the output file is not pretouched.
Review comment:
Alternatively, can we fix the Hive ORC data source to always write the
file? This seems wrong to me. We should at least write one file even if the
input query is empty, to record the output schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
