mridulm commented on pull request #35146: URL: https://github.com/apache/spark/pull/35146#issuecomment-1008448763
Given that `isStale` is used in a few places, it would be better to fix the `null` issue there itself. Can you try with: `return null == appShuffleMergePartitionsInfo || appShuffleMergePartitionsInfo.shuffleMergeId > shuffleMergeId;` for isStale @pan3793 ? We also need to ensure we have tests which check for stale but not too late as well - this specific codepath is an excellent test case for it. +CC @otterc, @Ngone51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
