cloud-fan commented on a change in pull request #35149:
URL: https://github.com/apache/spark/pull/35149#discussion_r780869362
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEPropagateEmptyRelation.scala
##########
@@ -40,6 +41,16 @@ object AQEPropagateEmptyRelation extends
PropagateEmptyRelationBase {
private def getRowCount(plan: LogicalPlan): Option[BigInt] = plan match {
Review comment:
I'd suggest renaming this to `getEstimatedRowCount` with a comment to
say that it can be over estimated if row count is not 0, to match the new
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
