zero323 commented on a change in pull request #35152:
URL: https://github.com/apache/spark/pull/35152#discussion_r780972394
##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -3399,8 +3399,8 @@ def resolve(internal: InternalFrame, side: str) ->
InternalFrame:
left_join_on_columns = [scol_for(left_table, label) for label in
left_join_on_names]
right_join_on_columns = [scol_for(right_table, label) for label in
right_join_on_names]
on = reduce(
- lambda l, r: l & r,
- [l == r for l, r in zip(left_join_on_columns,
right_join_on_columns)],
+ lambda lft, r: lft & r,
+ [lft == r for lft, r in zip(left_join_on_columns,
right_join_on_columns)],
Review comment:
We could convert the other argument to something like `rgt`.
Current naming kind of suggests there is some asymmetry here and `r ` is
different type of object from `lft`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
