cloud-fan commented on a change in pull request #35145:
URL: https://github.com/apache/spark/pull/35145#discussion_r781138528
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
##########
@@ -47,6 +47,18 @@ private object H2Dialect extends JdbcDialect {
assert(f.inputs().length == 1)
val distinct = if (f.isDistinct) "DISTINCT " else ""
Some(s"STDDEV_SAMP($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "COVAR_POP" =>
+ assert(f.inputs().length == 2)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"COVAR_POP($distinct${f.inputs().head}, ${f.inputs().last})")
+ case f: GeneralAggregateFunc if f.name() == "COVAR_SAMP" =>
+ assert(f.inputs().length == 2)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"COVAR_SAMP($distinct${f.inputs().head}, ${f.inputs().last})")
+ case f: GeneralAggregateFunc if f.name() == "CORR" =>
+ assert(f.inputs().length == 2)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"CORR($distinct${f.inputs().head}, ${f.inputs().last})")
case _ => None
}
Review comment:
do we cover all the aggregate functions (defined by DS v2) in H2 now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
