yikf commented on a change in pull request #35158:
URL: https://github.com/apache/spark/pull/35158#discussion_r781738126
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##########
@@ -353,7 +353,7 @@ case class DataSource(
case (dataSource: RelationProvider, Some(schema)) =>
val baseRelation =
dataSource.createRelation(sparkSession.sqlContext,
caseInsensitiveOptions)
- if (baseRelation.schema != schema) {
+ if (baseRelation.schema.withoutMetadata != schema.withoutMetadata) {
Review comment:
It ignore `nullable`, It is possible have a chance to occur failure in
query later? For example, In old 3.1, nullable is true, and there are some
null value actually, But nullable is false now, I'm not sure that if have a
chance to occur failure of the query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
