huaxingao commented on pull request #35156: URL: https://github.com/apache/spark/pull/35156#issuecomment-1009579698
@kazuyukitanimura Thanks for working on this! Overall the PR looks good to me. I am just thinking the newly added test `DataSourceV2StrategySuite` is sufficient for the change. It seems to me that we only need to test if the boolean column filter can be translated correctly, but we don't have to add a new test in `DataSourceV2Suite` to check if the boolean column filter can be pushed down. If a filter can be translated correctly, it should be pushed down for sure. That path has been very well tested, so I guess we can keep the test simple :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
