MaxGekk commented on a change in pull request #24173:
URL: https://github.com/apache/spark/pull/24173#discussion_r781817970



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
##########
@@ -753,6 +755,89 @@ class StreamingAggregationSuite extends 
StateStoreMetricsTest with Assertions {
     )
   }
 
+  testQuietlyWithAllStateVersions("changing schema of state when restarting 
query",

Review comment:
       The test still fails periodically:
   ```
   [info] - changing schema of state when restarting query - state format 
version 1 *** FAILED *** (1 second, 171 milliseconds)
   [info]   Error while checking stream failure: stateSchemaExc.isDefined was 
false
   [info]   
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
   [info]       
org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
   [info]       
org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
   [info]       
org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
   [info]       
org.apache.spark.sql.streaming.StreamingAggregationSuite.$anonfun$new$82(StreamingAggregationSuite.scala:781)
   [info]       
org.apache.spark.sql.streaming.StreamingAggregationSuite.$anonfun$new$82$adapted(StreamingAggregationSuite.scala:779)
   [info]       
org.apache.spark.sql.streaming.StreamTest.$anonfun$testStream$33(StreamTest.scala:642)
   [info]       
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
   [info]       
org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
   [info]       
org.scalatest.concurrent.TimeLimits.failAfterImpl(TimeLimits.scala:239)
   [info]   
   [info]   
   [info]   == Progress ==
   [info]      
StartStream(ProcessingTimeTrigger(0),org.apache.spark.util.SystemClock@50c50d34,Map(),/home/runner/work/spark/spark/target/tmp/spark-1ee805db-b75b-4469-a5e9-dbc39d212620)
   [info]      AddData to MemoryStream[value#33761]: 21
   [info]   => ExpectFailure[org.apache.spark.SparkException, isFatalError: 
false]
   [info]   
   [info]   == Stream ==
   [info]   Output Mode: Update
   [info]   Stream state: {MemoryStream[value#33761]: 0}
   [info]   Thread state: dead
   ```
   How about to disable it, and create a blocker JIRA for the next release to 
enable it back? @HyukjinKwon WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to