HyukjinKwon commented on a change in pull request #35167:
URL: https://github.com/apache/spark/pull/35167#discussion_r782697894
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1311,7 +1312,9 @@ def _select_cols_by_iterable(
% (len(cast(Sized, cols_sel)),
len(self._internal.column_labels))
)
if isinstance(cols_sel, pd.Series):
- if not
cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+ if get_option("compute.eager_check") and not
cols_sel.index.sort_values().equals(
+ self._psdf.columns.sort_values()
Review comment:
Oh I see .. we should probably fix that case then.. maybe let's create a
new PR to address that problem first, and then get this one merged after that.
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1311,7 +1312,9 @@ def _select_cols_by_iterable(
% (len(cast(Sized, cols_sel)),
len(self._internal.column_labels))
)
if isinstance(cols_sel, pd.Series):
- if not
cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+ if get_option("compute.eager_check") and not
cols_sel.index.sort_values().equals(
+ self._psdf.columns.sort_values()
Review comment:
cc @ueshin FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
