Peng-Lei commented on pull request #34719:
URL: https://github.com/apache/spark/pull/34719#issuecomment-1010689654
do sumary
Test case:
1.Move the testcase from `DDLParserSuite.scala` to
`ShowCreateTableParserSuite.scala`.
2.Move the testcase from `DataSourceV2SQLSuite` to `v2.ShowCreateTableSuite`.
If the test case also work with V1/Hive, then move to
ShowCreateTableSuiteBase
3.Move the testcase from `sql/ShowCreateTableSuite.scala` to
`v1.ShowCreateTableSuite`
If the test case also work with Hive, then move to
`v1.ShowCreateTableSuiteBase`
If the test case also work with V2/Hive, then move to
`ShowCreateTableSuiteBase`
4.Move the testcase from `HiveShowCreateTableSuite` to
`hive.ShowCreateTableSuite`
If the test case also work with V1/V2, then move to
`ShowCreateTableSuiteBase`
If the test case also work with V1, then move to
`v1.ShowCreateTableSuiteBase`
5.Use `getShowCreateDDL` instead of `checkCreateTable` to check the result.
code:
1.Add one space after `create table xxx` for the command `SHOW CREATE TABLE
AS SERDE` to unify the output.
2.Add one space after `OPTIONS` for v2 command `SHOW CREATE TABLE` to unify
the output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
