cloud-fan commented on pull request #34848: URL: https://github.com/apache/spark/pull/34848#issuecomment-1010738703
Can we follow `LPadExpressionBuilder`? I think the tricky part is type coercion, and my proposal is to follow lpad/rpad: 1. contains(binary, binary) -> convert to binary contains 2. for others, convert to string contains and rely on type coercion This means, for `contains(binary, string)`, we cast the binary to string, which is the same as the old behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
