Yikun commented on a change in pull request #35176:
URL: https://github.com/apache/spark/pull/35176#discussion_r783004394



##########
File path: 
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh
##########
@@ -36,6 +36,10 @@ if [ -z "$uidentry" ] ; then
     fi
 fi
 
+if [ -z "$JAVA_HOME" ]; then
+  JAVA_HOME=$(java -XshowSettings:properties -version 2>&1 > /dev/null | grep 
'java.home' | awk '{print $3}')

Review comment:
       Maybe we could create a softlink in dockerfile and then import JAVA_HOME 
to this softlink, then we don't need change entrypoint.
   
   ```
   RUN ln -sf  /usr/lib/jvm/java-17-openjdk-$(dpkg --print-architecture)/ 
/usr/local/openjdk-17
   ENV JAVA_HOME /usr/local/openjdk-17
   ```
   
   Anyway, if we can confirm `JAVA_HOME` is loaded as expected, we will don't 
need this workaround. I wrong to thought that jdk17 is also point to 
$JAVA_HOME/jre, but from your log, it 
works(`JAVA_HOME=/usr/lib/jvm/java-17-openjdk-arm64`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to