yangwwei commented on pull request #34672: URL: https://github.com/apache/spark/pull/34672#issuecomment-1011570638
I checked two open-source projects, Uber Zeus and Tencent Firestorm, they both did not implement `ShuffleBlockResolver `, see firestorm [RssShuffleManager#shuffleBlockResolver()](https://github.com/Tencent/Firestorm/blob/0cac0134da6c791c3077e683b2ac6b02e6546b06/client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java#L470-L473), and Zeus's [RssShuffleBlockResolver](https://github.com/uber/RemoteShuffleService/blob/607358d97dc17e1d4e8d29b145e43248ac9ef6dd/src/main/scala/org/apache/spark/shuffle/RssShuffleBlockResolver.scala#L20). They have both implemented ShuffleManager, and their own shuffle read/writer. So if we start the refactoring from this level, that might not help, what do you think, @attilapiros ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
