Yikun commented on a change in pull request #34646:
URL: https://github.com/apache/spark/pull/34646#discussion_r784675451
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
##########
@@ -276,11 +276,6 @@ private[spark] class BasicExecutorFeatureStep(
.editOrNewMetadata()
.withName(name)
.addToLabels(kubernetesConf.labels.asJava)
- .addToLabels(SPARK_RESOURCE_PROFILE_ID_LABEL,
resourceProfile.id.toString)
- .addToLabels(
- SPARK_APP_NAME_LABEL,
- KubernetesConf.getAppNameLabel(kubernetesConf.appName)
- )
Review comment:
FYI, these labels are ready included in KubernetesExecutorConf.labels:
https://github.com/apache/spark/blob/068d53bd5d89c96bf0cdb05d3ec7f2f023cf3875/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala#L158-L165
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -142,7 +142,6 @@ private[spark] class BasicDriverFeatureStep(conf:
KubernetesDriverConf)
.editOrNewMetadata()
.withName(driverPodName)
.addToLabels(conf.labels.asJava)
- .addToLabels(SPARK_APP_NAME_LABEL,
KubernetesConf.getAppNameLabel(conf.appName))
Review comment:
FYI, this label are ready included by KubernetesDriverConf.labels:
https://github.com/apache/spark/blob/068d53bd5d89c96bf0cdb05d3ec7f2f023cf3875/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala#L96-L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
