viirya commented on a change in pull request #35208:
URL: https://github.com/apache/spark/pull/35208#discussion_r785058052
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala
##########
@@ -111,6 +111,7 @@ object TreePattern extends Enumeration {
val PROJECT: Value = Value
val RELATION_TIME_TRAVEL: Value = Value
val REPARTITION_OPERATION: Value = Value
+ val REBALANCE: Value = Value
Review comment:
nit: REBALANCE_PARTITION?
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala
##########
@@ -294,4 +294,20 @@ class PropagateEmptyRelationSuite extends PlanTest {
val expected = LocalRelation.fromExternalRows(Seq('a.int, 'b.int, 'c.int),
Nil)
comparePlans(optimized, expected)
}
+
+ test("SPARK-37904: Improve rebalance in PropagateEmptyRelation") {
+ val emptyRelation = LocalRelation($"a".int)
+
+ // test root node
+ val plan1 = emptyRelation.rebalance($"a").analyze
+ val optimized1 = Optimize.execute(plan1)
+ val expected1 = emptyRelation.analyze
Review comment:
nit: `expected1` and `expected2` are same. Maybe just `expected`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
