AngersZhuuuu commented on a change in pull request #35207:
URL: https://github.com/apache/spark/pull/35207#discussion_r785259672
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -50,6 +50,8 @@ trait InvokeLike extends Expression with NonSQLExpression
with ImplicitCastInput
def propagateNull: Boolean
+ override def foldable: Boolean =
+ children.forall(_.foldable) && !dataType.isInstanceOf[ObjectType]
Review comment:
> I meant to just remove `ObjectType` since `ObjectType` is not
supported in `Literal` anyway so this condition is uesless .. or did I miss
something?
Discussed with @cloud-fan , ObjectType only used in InvokeLike. WDYT
@cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
