attilapiros commented on pull request #35180: URL: https://github.com/apache/spark/pull/35180#issuecomment-1013889930
My idea for a follow-up PR is to introduce interfaces along the capabilities so instead of the `IndexShuffleBlockResolver` we would cast to those capabilities. Example `SameHostStoredShuffleBlockResolver` with the `getBlockData` method. In this case when a custom shuffle manager gives back a block resolver which implements this interface the `getBlockData` can be used by the block manager. But right now I am busy with the `MapStatus` (I would like to open a PR for the `MapStatus` next week). We can let this PR open and when I have time I can proceed with the capability based solution, although I still think this cleanup is useful on its own as stabilizes the `ShuffleBlockResolver` which can cause build error in the 3rd party solutions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
