cloud-fan commented on a change in pull request #34848:
URL: https://github.com/apache/spark/pull/34848#discussion_r785708632
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -464,8 +465,27 @@ abstract class StringPredicate extends BinaryExpression
override def toString: String = s"$nodeName($left, $right)"
}
+trait StringBinaryPredicateExpressionBuilderBase extends ExpressionBuilder {
+ override def build(expressions: Seq[Expression]): Expression = {
+ val numArgs = expressions.length
+ if (numArgs == 2) {
+ if (expressions(0).dataType == BinaryType && expressions(1).dataType ==
BinaryType) {
+ createBinaryPredicate(expressions(0), expressions(1))
+ } else {
+ createStringPredicate(expressions(0), expressions(1))
+ }
+ } else {
+ throw QueryCompilationErrors.invalidFunctionArgumentNumberError(Seq(2),
funcName, numArgs)
+ }
+ }
+
+ protected def funcName: String
+ protected def createBinaryPredicate(left: Expression, right: Expression):
Expression
+ protected def createStringPredicate(left: Expression, right: Expression):
Expression
+}
+
/**
- * A function that returns true if the string `left` contains the string
`right`.
+ * Returns true if `left` contains `right`. Both expressions must be of STRING
or BINARY type.
Review comment:
We can remove this and update the `usage` doc below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
