cloud-fan commented on a change in pull request #35130:
URL: https://github.com/apache/spark/pull/35130#discussion_r785767123
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
##########
@@ -874,4 +876,47 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
checkAnswer(df, Seq(Row(2)))
// scalastyle:on
}
+
+ private def checkAverageConversion(df: DataFrame): Unit = {
Review comment:
this does not check the partial agg pushdown. I think we need to test
two cases:
1. the JDBC table has only 1 partition and supports complete pushdown, so
there is no agg operator at Spark side (optimized plan)
2. the JDBC table doesn't support complete pushdown, there is still an agg
operator at Spark side (optimized plan) but the scan relation output contains
aggregated result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
