yoda-mon commented on pull request #34896:
URL: https://github.com/apache/spark/pull/34896#issuecomment-1014354761
@MaxGekk
Gentle reminder,
- Extending `TimeZoneAwareExpression` seems not so simple.
- `sourceTz` is not ignored so I have to set appropriate timezone there.
- At the constructor, `timeZoneId` by mix-in could not be used because it
would be copied after that point.
- At `nullSafeEval` or `doGenCode` I could use `timeZoneId`, but I have
to check whether `sourceTs` is `TimeStampNTZ` or `TimeStampLTZ` so I have to
pass it in some ways.
I think there is small benefit for mixing `TimeZoneAwareExpression`... Is
the first idea is simple enough to add the option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
