cloud-fan commented on a change in pull request #35220:
URL: https://github.com/apache/spark/pull/35220#discussion_r786430773
##########
File path:
sql/core/src/test/resources/sql-tests/results/typeCoercion/native/concat.sql.out
##########
@@ -40,16 +40,16 @@ FROM (
-- !query schema
struct<col:string>
-- !query output
-prefix_0120.0
-prefix_1231.0
-prefix_2342.0
-prefix_3453.0
-prefix_4564.0
-prefix_5675.0
-prefix_6786.0
-prefix_7897.0
-prefix_89108.0
-prefix_910119.0
+prefix_0120
+prefix_1231
+prefix_2342
+prefix_3453
+prefix_4564
+prefix_5675
+prefix_6786
+prefix_7897
+prefix_89108
+prefix_910119
Review comment:
yea, long -> double is not a 100% safe upcast because it may truncate.
How about we define a `isWiderCast` in this rule and only put 100% safe upcast
there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
