sunchao commented on a change in pull request #35243:
URL: https://github.com/apache/spark/pull/35243#discussion_r788040266
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -259,6 +262,7 @@ case class StaticInvoke(
override def nullable: Boolean = needNullCheck || returnNullable
override def children: Seq[Expression] = arguments
+ override lazy val deterministic: Boolean = isDeterministic &&
arguments.forall(_.deterministic)
Review comment:
I thought about this too, but then we'd have to move `isDeterministic`
there too and then override it in `StaticInvoke` and `Invoke`, so doesn't seem
we can save much. Plus I think deterministic property is not useful for
`NewInstance`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
