xuanyuanking commented on a change in pull request #35238:
URL: https://github.com/apache/spark/pull/35238#discussion_r788516739
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
##########
@@ -77,7 +77,9 @@ private[kafka010] class KafkaSource(
metadataPath: String,
startingOffsets: KafkaOffsetRangeLimit,
failOnDataLoss: Boolean)
- extends SupportsAdmissionControl with Source with Logging {
+ extends SupportsTriggerAvailableNow
+ with Source
+ with Logging {
Review comment:
super nit: maybe still keep all the extends in one-line?
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
##########
@@ -98,7 +100,7 @@ private[kafka010] class KafkaMicroBatchStream(
} else if (minOffsetPerTrigger.isDefined) {
ReadLimit.minRows(minOffsetPerTrigger.get, maxTriggerDelayMs)
} else {
-
maxOffsetsPerTrigger.map(ReadLimit.maxRows).getOrElse(super.getDefaultReadLimit)
+
maxOffsetsPerTrigger.map(ReadLimit.maxRows).getOrElse(ReadLimit.allAvailable())
Review comment:
how about fill a Spark Jira with the detailed description. Then we just
need a single line comment here like:
```
TODO(SPARK-xxxx): directly call super.getDefaultReadLimit when ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
