cloud-fan commented on a change in pull request #35060:
URL: https://github.com/apache/spark/pull/35060#discussion_r788554017
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/NumberFormatterSuite.scala
##########
@@ -19,76 +19,75 @@ package org.apache.spark.sql.catalyst.util
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.AnalysisException
-import org.apache.spark.sql.catalyst.util.NumberUtils.{format, parse}
import org.apache.spark.sql.types.Decimal
import org.apache.spark.unsafe.types.UTF8String
-class NumberUtilsSuite extends SparkFunSuite {
+class NumberFormatterSuite extends SparkFunSuite {
- private def failParseWithInvalidInput(
- input: UTF8String, numberFormat: String, errorMsg: String): Unit = {
- val e = intercept[IllegalArgumentException](parse(input, numberFormat))
+ private def invalidNumberFormat(numberFormat: String, errorMsg: String):
Unit = {
+ val testNumberFormatter = new TestNumberFormatter(numberFormat)
Review comment:
do we really need this `TestNumberFormatter`? We can simply call
`check`, expect it to return `TypeCheckFailure`, and check the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
