cloud-fan commented on a change in pull request #35254:
URL: https://github.com/apache/spark/pull/35254#discussion_r788728066



##########
File path: 
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
##########
@@ -204,7 +204,8 @@ object FileCommitProtocol extends Logging {
       className: String,
       jobId: String,
       outputPath: String,
-      dynamicPartitionOverwrite: Boolean = false): FileCommitProtocol = {
+      dynamicPartitionOverwrite: Boolean = false,
+      staticPartitionInsert: Boolean = false): FileCommitProtocol = {

Review comment:
       hmm, adding one more parameter to the commit protocol API looks a bit 
overkill to fix this problem, which users can just disable writing the 
`_SUCCESS` file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to