AngersZhuuuu commented on a change in pull request #35229:
URL: https://github.com/apache/spark/pull/35229#discussion_r789303753
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2953,27 +2953,9 @@ class HiveDDLSuite
|NAMED_STRUCT('ID', ID, 'IF(ID=1,ID,0)', IF(ID=1,ID,0), 'B',
ABS(ID)) AS col1
|FROM v
""".stripMargin)
- }.getMessage
- assert(e.contains("Column name \"IF(ID=1,ID,0)\" contains" +
- " invalid character(s). Please use alias to rename it."))
- }
- }
- }
-
- test("SPARK-36312: ParquetWriteSupport should check inner field") {
Review comment:
No exception thrown by hive serde, seems hive serder won't check inner
fields. So just remove this .
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2953,27 +2953,9 @@ class HiveDDLSuite
|NAMED_STRUCT('ID', ID, 'IF(ID=1,ID,0)', IF(ID=1,ID,0), 'B',
ABS(ID)) AS col1
|FROM v
""".stripMargin)
- }.getMessage
- assert(e.contains("Column name \"IF(ID=1,ID,0)\" contains" +
- " invalid character(s). Please use alias to rename it."))
- }
- }
- }
-
- test("SPARK-36312: ParquetWriteSupport should check inner field") {
Review comment:
No exception thrown by hive serde, seems hive serder won't check inner
fields. So just remove this . cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
