cloud-fan commented on a change in pull request #35246:
URL: https://github.com/apache/spark/pull/35246#discussion_r789412358
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -278,7 +278,9 @@ class JDBCTableCatalog extends TableCatalog with
SupportsNamespaces with Logging
}
}
- override def dropNamespace(namespace: Array[String]): Boolean = namespace
match {
+ override def dropNamespace(
+ namespace: Array[String],
+ cascade: Boolean): Boolean = namespace match {
Review comment:
Can you create a followup PR to fix JDBC source? We need to respect the
cascade parameter. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
