AngersZhuuuu commented on a change in pull request #35207:
URL: https://github.com/apache/spark/pull/35207#discussion_r789424740
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -50,6 +50,7 @@ trait InvokeLike extends Expression with NonSQLExpression
with ImplicitCastInput
def propagateNull: Boolean
+ override def foldable: Boolean = children.forall(_.foldable) && deterministic
Review comment:
> shall we remove `deterministic`? I don't see other expressions require
it when defining foldable.
If it's not `deterministic`, such as Invoke return a rand result, if we fold
this, we may return incorrect answer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
