cloud-fan commented on a change in pull request #35248:
URL: https://github.com/apache/spark/pull/35248#discussion_r789499565
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -860,3 +870,30 @@ object PushableColumnAndNestedColumn extends
PushableColumnBase {
object PushableColumnWithoutNestedColumn extends PushableColumnBase {
override val nestedPredicatePushdownEnabled = false
}
+
+/**
+ * Get the SQL string of an expression that can be pushed down.
+ */
+object PushableExpression {
Review comment:
The code size here can go very big very fast. I'd like to have a new
class `ExpressionSQLBuilder` in a new file, probably under the package
`org.apache.spark.sql.catalyst.utils`, in the `sql/core` module. It can be used
like `new ExpressionSQLBuilder(catalystExpr).build()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
