cloud-fan commented on a change in pull request #35268:
URL: https://github.com/apache/spark/pull/35268#discussion_r789500512



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -843,11 +843,10 @@ class HiveDDLSuite
       // The table type is not changed to external
       assert(
         catalog.getTableMetadata(TableIdentifier(tabName)).tableType == 
CatalogTableType.MANAGED)
-      // The table property is case sensitive. Thus, external is allowed
-      sql(s"ALTER TABLE $tabName SET TBLPROPERTIES ('external' = 'TRUE')")
-      // The table type is not changed to external
-      assert(
-        catalog.getTableMetadata(TableIdentifier(tabName)).tableType == 
CatalogTableType.MANAGED)
+      val e1 = intercept[ParseException] {
+        sql(s"ALTER TABLE $tabName SET TBLPROPERTIES ('external'='bar')")

Review comment:
       then let's use `External` and keep this test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to