srowen commented on a change in pull request #35278:
URL: https://github.com/apache/spark/pull/35278#discussion_r790167931
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -595,7 +593,7 @@ private[spark] object Utils extends Logging {
if (lowerSrc.endsWith(".jar")) {
RunJar.unJar(source, dest, RunJar.MATCH_ANY)
} else if (lowerSrc.endsWith(".zip")) {
- FileUtil.unZip(source, dest)
+ unZip(source.getAbsoluteFile, dest)
Review comment:
My point is, would that be helpful in all unzip scenarios? rather than
have two different implementations
Adding a dependency on the OS package is probably OK but not sure
Can you add python/python3 to the execution? that seems more standard but
not sure if it is possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
