dcoliversun commented on a change in pull request #35215:
URL: https://github.com/apache/spark/pull/35215#discussion_r790207979
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtils.scala
##########
@@ -88,9 +88,8 @@ private[spark] object KubernetesClientUtils extends Logging {
* on remote pods.
*/
def buildConfigMap(configMapName: String, confFileMap: Map[String, String],
- withLabels: Map[String, String] = Map()): ConfigMap = {
- val configMapNameSpace =
- confFileMap.getOrElse(KUBERNETES_NAMESPACE.key,
KUBERNETES_NAMESPACE.defaultValueString)
+ configMapNameSpace: String,
Review comment:
Hi，I don't think it is a good idea to change this method signature.
Could you fix namespace in conFileMap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
