chia7712 commented on a change in pull request #35215:
URL: https://github.com/apache/spark/pull/35215#discussion_r790260807
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
##########
@@ -76,13 +76,12 @@ private[spark] class KubernetesClusterSchedulerBackend(
private def setUpExecutorConfigMap(driverPod: Option[Pod]): Unit = {
val configMapName = KubernetesClientUtils.configMapNameExecutor
- val resolvedExecutorProperties =
- Map(KUBERNETES_NAMESPACE.key -> conf.get(KUBERNETES_NAMESPACE))
val confFilesMap = KubernetesClientUtils
Review comment:
@dcoliversun @Yikun thanks for all your comments.
> Driver conFileMaps sets namespace in the same ways
It seems to me that it does not propagate namespace configured by ‘
spark.kubernetes.namespace’ to buildCpnfigMap. We don’t explicitly assign the
namespace of configmap before #34983, so it is fine. After we assign the
namespace of configmap explicit, it is possible to cause error (on my local)
when the true namespace is not propagated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
